Back to the main page.
Bug 2099 - ft_preproc_padding fails for padtype mirror
| Status | CLOSED FIXED |
| Reported | 2013-04-10 16:51:00 +0200 |
| Modified | 2014-03-12 12:21:44 +0100 |
| Product: | FieldTrip |
| Component: | preproc |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | Jörn M. Horschig |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Arjen Stolk - 2013-04-10 16:51:59 +0200
In line 79 it states the variable 'padlength'. This variable is never specified. Likely, 'postpadlength' was intended here?
Jörn M. Horschig - 2013-04-10 17:12:39 +0200
yep exactly... wondering how that could have happened... ;) gonna change it in a bit
Jörn M. Horschig - 2013-04-10 17:14:23 +0200
665 $ svn ci ft_preproc_padding.m -m "bugfix #2099 - variable name corrected" Sending ft_preproc_padding.m Transmitting file data . Committed revision 7774.
Arjen Stolk - 2013-04-10 18:16:58 +0200
svn :o :D
Arjen Stolk - 2013-04-10 21:01:26 +0200
http://code.google.com/p/fieldtrip/source/diff?spec=svn7774&r=7774&format=side&path=/trunk/preproc/ft_preproc_padding.m I think the lines 44-46 are not ncessary. In fact they cause another error ( http://code.google.com/p/fieldtrip/source/detail?r=7774 ). Namely, the variable padlength is never specified, also not in the function call: function [dat] = ft_preproc_padding(dat, padtype, prepadlength, postpadlength) :)
Arjen Stolk - 2013-04-10 21:04:49 +0200
Just for clarity; deleting those lines 44-46 should solve the 'new' problem. The 'old' problem you have solved already.
Robert Oostenveld - 2013-04-10 21:22:02 +0200
I noticed a large number of test scripts failing on the dashboard, which turned out to be due to an unknown variable padlength in ft_preproc_padding. Apparently something went wrong here. I fixed the previous fix. roboos@mentat001> svn commit Sending preproc/ft_preproc_padding.m Transmitting file data . Committed revision 7777.
Arjen Stolk - 2013-04-10 21:24:35 +0200
Hehe, you just beat me to it. bash-4.1$ svn commit ft_preproc_padding.m Sending ft_preproc_padding.m Transmitting file data .svn: Commit failed (details follow): svn: File '/trunk/preproc/ft_preproc_padding.m' is out of date svn: Your commit message was left in a temporary file: svn: '/home/action/arjsto/fieldtrip-svn/preproc/svn-commit.tmp'
Arjen Stolk - 2013-04-10 21:27:29 +0200
Just tested the new ft_preproc_padding and it works perfectly fine now.