Back to the main page.
Bug 1143 - begsample and endsample not processed for gdf in ft_read_event
| Status | CLOSED FIXED |
| Reported | 2011-11-11 12:28:00 +0100 |
| Modified | 2012-06-20 15:03:22 +0200 |
| Product: | FieldTrip |
| Component: | fileio |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P3 normal |
| Assigned to: | Boris Reuderink |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=1281 |
Andrei Belitski - 2011-11-11 12:28:48 +0100
Hi guys, small thing: it seems that I can't specify a sample range to process events of a gdf file. In ft_read_event.m on line 364 begsample and endsample are not passed to the read_trigger function that created an out of memory error, as my gdf is rather large and the evoked biosig toolbox command tries to read it all at once. so I fixed it in my local copy by providing those parameters. thanks Andrei
Robert Oostenveld - 2011-11-11 15:31:03 +0100
Can you send the change that you made to the function with the approximate line number? As diff, patch, or just copy and paste the section you changed.
Andrei Belitski - 2011-11-11 16:20:19 +0100
Created attachment 186 the modified ft_read_event.m file to handle sample range for gdf format I only modified line 364 to add the 'minsample' and 'maxsample' also note: it seems that most other functions like ft_read_data or read_trigger use 'begsample' and 'endsample' to specify a range, whereas in ft_read_event the parameters are called 'minsample' and 'maxsample', may be would nice to make it consistent to avoid confusion thanks
Robert Oostenveld - 2011-11-11 16:39:15 +0100
> also note: it seems that most other functions like ft_read_data or read_trigger > use 'begsample' and 'endsample' to specify a range, whereas in ft_read_event > the parameters are called 'minsample' and 'maxsample', may be would nice to > make it consistent to avoid confusion That is indeed something to consider. The full specification of event selection (which is especially relevant for inline realtime systems) is defined in fileio/ft_filter_event.
Boris Reuderink - 2012-01-17 12:21:09 +0100
Added time estimate.
Boris Reuderink - 2012-02-01 17:30:17 +0100
I have incorporated your fix, see SVN revision 5223 (note that I referred to the wrong bug in the commit msg!). @Andrei, could you verify that the changed code does indeed work as you intended?
Boris Reuderink - 2012-02-01 17:36:05 +0100
(In reply to comment #5) BTW, please note that *tonight* (2012-2-1) there will be no fieldtrip release related to the huge number of fixes that we made. So, please use the version of 2012-2-2 for verification.
Robert Oostenveld - 2012-02-04 10:50:42 +0100
(In reply to comment #6) Following the bug-binge, the last few days we have not had any internal issues with our "beta testers". So I have re-enabled the automatic ftp release script.